search

gazebosim / sdformat

Simulation Description Format (SDFormat) parser and description files.
http://sdformat.org
Apache License 2.0
152 stars 90 forks source link

Enable 24.04 CI, remove distutils dependency #1408

Closed scpeters closed 1 month ago

scpeters commented 2 months ago

🎉 New feature

Attempting to enable CI on 24.04

Summary

The python3-distutils package is not available on 24.04, but we only use it in a codepath for old versions of cmake. Since we are already requiring cmake 3.22.1 in gz-cmake4, we can require that version in sdformat15 as well and remove code for old versions of cmake.

Test it

Observe CI results

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Blast545 commented 1 month ago

:farmer: @scpeters Can this one be backported to sdf14? I think it should fix CI on Harmonic+Noble, see: https://build.osrfoundation.org/job/sdformat-ci-sdf14-noble-amd64/4/console

I am not sure if the cmake bump can be done there too.

scpeters commented 1 month ago

🧑‍🌾 @scpeters Can this one be backported to sdf14? I think it should fix CI on Harmonic+Noble, see: https://build.osrfoundation.org/job/sdformat-ci-sdf14-noble-amd64/4/console

I am not sure if the cmake bump can be done there too.

I would not backport the change in minimum required cmake version to sdf14, but the other changes can be back ported

scpeters commented 1 month ago

🧑‍🌾 @scpeters Can this one be backported to sdf14? I think it should fix CI on Harmonic+Noble, see: https://build.osrfoundation.org/job/sdformat-ci-sdf14-noble-amd64/4/console I am not sure if the cmake bump can be done there too.

I would not backport the change in minimum required cmake version to sdf14, but the other changes can be back ported

actually maybe we could backport the cmake 3.22.1 changes to sdf14? It already requires 22.04

Blast545 commented 1 month ago

@scpeters Will do, opening a PR now