gazebosim / sdformat

Simulation Description Format (SDFormat) parser and description files.
http://sdformat.org
Apache License 2.0
152 stars 90 forks source link

(Backport) Enable 24.04 CI, remove distutils dependency (#1408) #1413

Closed Blast545 closed 1 month ago

Blast545 commented 1 month ago

🦟 Bug fix

Should fix CI on sdformat for Harmonic. See reference job: https://build.osrfoundation.org/job/sdformat-ci-sdf14-noble-amd64/

Summary

Backporting the removal of the distutils dependency

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.44%. Comparing base (ff9b3ad) to head (e100e03). Report is 12 commits behind head on sdf14.

:exclamation: Current head e100e03 differs from pull request most recent head 47e82ba. Consider uploading reports for the commit 47e82ba to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## sdf14 #1413 +/- ## ========================================== + Coverage 92.42% 92.44% +0.01% ========================================== Files 134 135 +1 Lines 17751 17837 +86 ========================================== + Hits 16406 16489 +83 - Misses 1345 1348 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Blast545 commented 1 month ago

@scpeters ABI checker is failing on the CMake version :/

scpeters commented 1 month ago

@scpeters ABI checker is failing on the CMake version :/

I think this is a problem with infra and not this PR; let's try to fix the infra