gazebosim / sdformat

Simulation Description Format (SDFormat) parser and description files.

http://sdformat.org

Apache License 2.0

152 stars 90 forks source link

Update default camera instrinsics skew to 0, which matches spec #1423

Closed shameekganguly closed 1 month ago

shameekganguly commented 1 month ago

🦟 Bug fix

Summary

Default camera lens intrinsics skew is 0 in the camera sdf spec: https://github.com/gazebosim/sdformat/blob/sdf14/sdf/1.11/camera.sdf But the default value in sdf::Camera class was set to 1. I've fixed this value to match the spec in this PR and updated the associated tests.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

azeey commented 1 month ago

Is this change worth announcing on discourse? It could be a breaking change for some folks, but I don't have a sense of how many people will be affected.

iche033 commented 1 month ago

I think it's a bugfix that we can mention the change in Migration guide? I imagine most people will be setting skew to 0.

azeey commented 1 month ago

Okay. Adding to the migration guide sounds good. @shameekganguly/@iche033 mind doing that now so we don't forget next time we make a release?

iche033 commented 1 month ago

yep I'll take care of it