gazebosim / sdformat

Simulation Description Format (SDFormat) parser and description files.
http://sdformat.org
Apache License 2.0
166 stars 92 forks source link

workflows/ci.yml fix push branch regex #1445

Closed scpeters closed 3 months ago

scpeters commented 3 months ago

🦟 Bug fix

Fixes triggering of GitHub workflows on branches with double-digit major version.

Summary

Ubuntu workflows for branches with a double digit major version number haven't been running for a while (6 months since the last sdf14 build). I believe this is due to the regex pattern used to match our release branches.

The current pattern matches the following: "sdf", "sdf0", "sdf1", ..., "sdf8", "sdf9" of which "sdf" is incorrect, and only "sdf9" is currently supported. This updates the pattern to match single digits "sdf1" - "sdf9" and double digits "sdf10" to "sdf99".

I don't think we can test this without merging it?

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

scpeters commented 3 months ago

the Noble workflow failure is due to https://github.com/gazebo-tooling/action-gz-ci/issues/76