gazebosim / sdformat

Simulation Description Format (SDFormat) parser and description files.

http://sdformat.org

Apache License 2.0

169 stars 97 forks source link

Bump main to sdformat 16.0.0~pre1 #1487

Closed caguero closed 1 month ago

caguero commented 1 month ago

🎉 New feature

Summary

Bump main to sdformat 16.0.0~pre1

Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

iche033 commented 1 month ago

test fixing macOS github ci workflow: e4a4c68

scpeters commented 1 month ago

test fixing macOS github ci workflow: e4a4c68

that is a good fix, but the problem appears to be that homebrew added python@3.13 and our homebrew formula builds python bindings for gz-math8 with python@3.12 (see gz-math8.rb:23), but now cmake is finding python 3.13 when searching for the interpreter so tests fail when they can't find the gz-math8 bindings

We've faced this before; I think we can hard-code which python version we want to find, let me see if I can find it

scpeters commented 1 month ago

We've faced this before; I think we can hard-code which python version we want to find, let me see if I can find it

I think we need an adjustment to the -DPython_EXECUTABLE=... cmake arg to point to the version of python that we currently support

some homebrew formula build bindings for multiple versions of python, but that seems a bit complicated

scpeters commented 1 month ago

We've faced this before; I think we can hard-code which python version we want to find, let me see if I can find it

I think we need an adjustment to the -DPython_EXECUTABLE=... cmake arg to point to the version of python that we currently support

some homebrew formula build bindings for multiple versions of python, but that seems a bit complicated

I've opened https://github.com/osrf/homebrew-simulation/issues/2834 to track this issue

iche033 commented 1 month ago

the homebrew python issue is being addressed separately. Merging this in first.