Open scpeters opened 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Please upload report for BASE (
sdf15@4ebe022
). Learn more about missing BASE report.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
🎉 New feature
Similar to https://github.com/gazebosim/gz-math/pull/642 using https://github.com/gazebosim/gz-cmake/pull/456 from gz-cmake 4.1.0
Summary
When building python bindings separately from the main library, the major version of libsdformat has been hard-coded, but this changes it to parse the version number from the
package.xml
file in this repository using a gz-cmake feature added in https://github.com/gazebosim/gz-cmake/pull/456 and released in 4.1.0. We could also consider using this feature in the root CMakeLists.txt file, but for now it is just used when building python bindings separately from the main library.Test it
python
folder:sdformat15
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.