gazed / vu

Virtual Universe 3D Engine
BSD 2-Clause "Simplified" License
216 stars 26 forks source link

Consistent Color/Colour naming #3

Closed sharpner closed 8 years ago

sharpner commented 8 years ago

Hi! awesome library thanks for the hard work so far! I just started using it but I already fell in love :-)

But it would awesome if color would be named consistently within the library (preferably color :P).

In vu.Eng#SetColor its SetColor but in render.Light its SetColour/GetColour().

Thx!

gazed commented 8 years ago

Thank you for trying vu and taking the time to provide feedback.

I’ve made the change as you recommend and standardized on color throughout. The change is in the internal galvanized logic repo and it will appear next time the internal repo is released to github.

rust

On Nov 24, 2015, at 11:14 AM, Nino notifications@github.com wrote:

Hi! awesome library thanks for the hard work so far! I just started using it but I already fell in love :-)

But it would awesome if color would be named consistently within the library (preferably color :P).

In vu.Eng#SetColor its SetColor but in render.Light its SetColour/GetColour().

Thx!

— Reply to this email directly or view it on GitHub https://github.com/gazed/vu/issues/3.

sharpner commented 8 years ago

awesome! thank you

sharpner commented 8 years ago

yay =)