search

gazetteerhk / census_explorer

Explore Hong Kong's neighborhoods through visualizations of census data
http://gazetteer.hk
MIT License
42 stars 12 forks source link

Working frontend visualizations #36

Closed hxu closed 10 years ago

hxu commented 10 years ago

I think the frontend branch is in a pretty good state, and should be merged into master.

There's a ton of changes, but the main thrust of it is that there are now a handful of reusable components that can be combined to create visualizations. The /#/test page has been refactored to use these components.

After merging into frontend, I will focus on creating more individual apps and visualizations.

hxu commented 10 years ago

ping @hupili @vincentlaucy @2blam, let me know what you guys think.

hupili commented 10 years ago

:+1: for merge. We can have a running version (gh-pages have been broken for a while because it does not catch up backend upgrades).

hxu commented 10 years ago

Deployed, see it in action here: http://hxu.github.io/hk_census_explorer/#/test

debuggingfuture commented 10 years ago

cool hk_census_explorer/ is added as prefix? the locales files got below path and 404 http://hxu.github.io/locale/en-US/human_ns-translation.json

On Fri, Feb 14, 2014 at 2:42 AM, hxu notifications@github.com wrote:

Deployed, see it in action here: http://hxu.github.io/hk_census_explorer/#/test

Reply to this email directly or view it on GitHubhttps://github.com/hxu/hk_census_explorer/pull/36#issuecomment-35010813 .

hxu commented 10 years ago

Hm, I see that. This is related to the development vs. deploy config problem we had with the backend API pointer. Our dev environments won't have the hk_census_explorer prefix, so it'll break in dev if we change the prefix manually.

Any suggestions on a good strategy to solve?

debuggingfuture commented 10 years ago

this impl shows some options https://github.com/kanso/duality/blob/master/duality/utils.js#L114

23 used the serverPrefix which is set as constant for now

simplest one is to add this as baseUrl for all and externalize the config either by injection or build process?