search

gazetteerhk / census_explorer

Explore Hong Kong's neighborhoods through visualizations of census data
http://gazetteer.hk
MIT License
42 stars 12 forks source link

Add translation link #55

Open hxu opened 10 years ago

hxu commented 10 years ago

Should just append ?lang=zh-CN to the URL before the hash.

hupili commented 10 years ago

Can we make an option button and record everyone's language choice in local store? extra ?lang=zh-CN makes the URL different, not very friendly for page reference aggregation.

hxu commented 10 years ago

I'm open to that, and it looks like i18next supports that.

On Wed, Feb 26, 2014 at 5:40 PM, HU, Pili notifications@github.com wrote:

Can we make an option button and record everyone's language choice in local store? extra ?lang=zh-CN makes the URL different, not very friendly for page reference aggregation.

— Reply to this email directly or view it on GitHubhttps://github.com/gazetteerhk/census_explorer/issues/55#issuecomment-36201003 .

debuggingfuture commented 10 years ago

I think user should able to select the language in navbar. btw, i18next has both auto locale detect and session locale (after url ?setLng=zh-CN)

hxu commented 10 years ago

@vincentlaucy does the site default to Chinese for you when you visit it? Or can anyone with a non-English locale answer the question?