search

gazetteerhk / census_explorer

Explore Hong Kong's neighborhoods through visualizations of census data
http://gazetteer.hk
MIT License
42 stars 12 forks source link

Leaflet directive should be a bower dependency #8

Closed hxu closed 10 years ago

hxu commented 10 years ago

Looks like angular-leaflet-directive.js was installed manually. Should move this to a bower dependency so that it gets capture as a part of the frontend build process.

hupili commented 10 years ago

one note. grunt, grunt build will actually modify app/index.html for sections like:

    <!-- build:js scripts/vendor.js -->
    <!-- bower:js -->
...
    <!-- endbower -->
    <!-- endbuild -->

bower-incompatible packages should be moved out of those sections, and manual copy files in Gruntfile so that output dist is complete. bower requires a standard bower.json or fall back to component.json but some of the modules we include does not contain them.

hxu commented 10 years ago

Actually this is a problem with the bower-install task. This task is not essential, since we're manually adding bower packages to index.html. I've fixed this in 506e8ebb4.

debuggingfuture commented 10 years ago

fixed in b939317