gazorby / fifc

🐠 Configurable fzf completions for fish shell
MIT License
157 stars 11 forks source link

The plugin throws an error when pressing `tab` after typing some commands #2

Closed HamzaBow closed 2 years ago

HamzaBow commented 2 years ago

The plugin displays errors when executing some commands e.g. using it with the ls or exa commands causes an error, whereas pressing tab after typing git or bat doesn't cause any error and it works OK in the latter cases To Reproduce fisher install gazorby/fifc set -Ux fifc_editor vim

In the screenshot bellow I typed exa --color=always and then pressed tab and this happened:

image

I think it has to do with fd command, I have installed fd this way: sudo apt install fd-find and then I aliased it alias fd fdfind

System:

gazorby commented 2 years ago

Ok, it seems that --strip-cwd-prefix has been added in a recent release of fd (8.3.0) that you might no have installed.

HamzaBow commented 2 years ago

That was indeed the problem, I solved it by removing the fd package sudo apt remove fd And then I downloaded fd .deb package from this page https://github.com/sharkdp/fd/releases/tag/v8.4.0 and installed it using this command sudo apt install ./fd_<version-number>_<architecture>.deb Thanks a lot.

gazorby commented 2 years ago

Fixed in master, --strip-cwd-prefix is removed now. You can still add it using fifc_fd_opts

kidonng commented 2 years ago

No need to remove it, just do a simple version check is fine.

gazorby commented 2 years ago

Right, that was more a hotfix than a solution