gazorby / fifc

🐠 Configurable fzf completions for fish shell
MIT License
157 stars 11 forks source link

Allow override of rm and custom fzf options #49

Open ollehu opened 1 month ago

ollehu commented 1 month ago

It's not unusual to alias rm to something harmless when using, for example, trash to remove files/directories. This PR will enable the user to change that command. This PR also lets the user add additional argument to the fzf_cmd, something that was not working properly before (I believe?)

ollehu commented 1 month ago

Ping @gazorby

towry commented 1 month ago

Hi, how to customize the fzf opts based on your change?

ollehu commented 1 month ago

Hi, how to customize the fzf opts based on your change?

Sorry about that, just updated the README. You simply set the fifc_custom_fzf_opts variable. I, for example, do not like the hardcoded --exact flag, so I have set -U fifc_custom_fzf_opts +e in my config.

towry commented 1 month ago

To append a custom fzf command, for example to disable the --exact flag and increase the fuzziness

Thanks for your work, this is exactly the feature that I am missing. can't wait for this to be merged.

towry commented 1 month ago

I don't know if this error is caused by this change.

Expected a combining operator like '-a' at index 4                                                                                                                
 = directories _fifc_source_directories _fifc_comp_2 _fifc_comp_3 _fifc_comp_4 _fifc_comp_5 _fifc_comp_6 _fifc_comp_7 _fifc_comp_8 _fifc_comp_9[1]                                 
               ^                                                                                                                                                                   
/nix/store/2flxhkb7shp3r6s2h3n7b4db6q06ypfc-source/functions/_fifc_action.fish (line 1):                                                                                           
in function '_fifc_action' with arguments 'source'                                                                                                                                 
        called on line 1 of file /nix/store/2flxhkb7shp3r6s2h3n7b4db6q06ypfc-source/functions/_fifc.fish                                                                           
in command substitution                                                                                                                                                            
        called on line 25 of file /nix/store/2flxhkb7shp3r6s2h3n7b4db6q06ypfc-source/functions/_fifc.fish
gazorby commented 1 month ago

I don't know if this error is caused by this change.

Expected a combining operator like '-a' at index 4                                                                                                                
 = directories _fifc_source_directories _fifc_comp_2 _fifc_comp_3 _fifc_comp_4 _fifc_comp_5 _fifc_comp_6 _fifc_comp_7 _fifc_comp_8 _fifc_comp_9[1]                                 
               ^                                                                                                                                                                   
/nix/store/2flxhkb7shp3r6s2h3n7b4db6q06ypfc-source/functions/_fifc_action.fish (line 1):                                                                                           
in function '_fifc_action' with arguments 'source'                                                                                                                                 
        called on line 1 of file /nix/store/2flxhkb7shp3r6s2h3n7b4db6q06ypfc-source/functions/_fifc.fish                                                                           
in command substitution                                                                                                                                                            
        called on line 25 of file /nix/store/2flxhkb7shp3r6s2h3n7b4db6q06ypfc-source/functions/_fifc.fish

This PR has not been merged yet; this error must come from the last one I merged earlier this week.

gazorby commented 1 month ago

Hi @ollehu, Thanks for contributing! fifc_custom_fzf_opts seems interesting, I will check this out this week.

ollehu commented 1 month ago

I don't know if this error is caused by this change.

Expected a combining operator like '-a' at index 4                                                                                                                
 = directories _fifc_source_directories _fifc_comp_2 _fifc_comp_3 _fifc_comp_4 _fifc_comp_5 _fifc_comp_6 _fifc_comp_7 _fifc_comp_8 _fifc_comp_9[1]                                 
               ^                                                                                                                                                                   
/nix/store/2flxhkb7shp3r6s2h3n7b4db6q06ypfc-source/functions/_fifc_action.fish (line 1):                                                                                           
in function '_fifc_action' with arguments 'source'                                                                                                                                 
        called on line 1 of file /nix/store/2flxhkb7shp3r6s2h3n7b4db6q06ypfc-source/functions/_fifc.fish                                                                           
in command substitution                                                                                                                                                            
        called on line 25 of file /nix/store/2flxhkb7shp3r6s2h3n7b4db6q06ypfc-source/functions/_fifc.fish

Did you get this using this PR or main? If using this PR, how did you trigger it?