search

gazorby / fish-abbreviation-tips

💡 Help you remembering your abbreviations
MIT License
291 stars 7 forks source link

Fix abbrevation tips to work with vi mode #18

Closed ghost closed 2 years ago

ghost commented 2 years ago

Description

Default bind mode in fish is default which is stored in $fish_bind_mode variable. By default bind command binds keys in default mode. After enabling vi keybindings in fish, mode can be toggled between both insert mode and default mode. Thus, the bindings don't work for vi keybindings as we are normally in insert mode. This PR will enable abbrevation-tips binds in vi mode.

Related issues

This might solve issue #4, but I am not sure, as it is working unexpectedly sometimes https://github.com/gazorby/fish-abbreviation-tips/issues/4#issuecomment-670041104

Notes

okuuva commented 2 years ago

Just tested this and it fixed #4 for me. Takkâ!

Edit: just to clarify, I do use vi mode with fish.

gazorby commented 2 years ago

Hi @madk38!

Good catch on this one!

Looks good to me, I'will merge it