search

gazoscalvertos / Hass-Custom-Alarm

Yet another take on a home assistant custom alarm
221 stars 94 forks source link

Make versioning clearer #50

Closed danobot closed 5 years ago

danobot commented 5 years ago

Hi, I'm having a hard time figuring out what the latest version of this component is. There is a tag v1.3.1 and bwalarm.py contains:

  VERSION:  1.1.0
  MODIFIED: 03/08/18

It seems that version number refers to alarm.html which is being versioned separately to the Python component. It might help not to version these separately and instead include a version in the Readme file.

The master branch contains this information in bwalarm.py:

  VERSION:  1.0.4
  MODIFIED: 16/10/18

The new UI branch contains yet another version but with the same modified date:

  VERSION:  1.1.2
  MODIFIED: 16/10/18

Which one is the latest, stable released version? I would be happy to help explain versioning. Convention is that master contains released code and a corresponding version tag exists to mark that version in time. :)

Great work by the way, can't wait to see what's to come! :)

adipose commented 5 years ago

bwalarm.py contains:

VERSION: 1.0.4

as well as:

VERSION = '1.0.2'

I assume the second part is an error.