fix create init witness gas charge

gballet / go-ethereum

Official Go implementation of the Ethereum protocol

https://geth.ethereum.org

GNU Lesser General Public License v3.0

23 stars 13 forks source link

fix create init witness gas charge #484

Closed tanishqjasoria closed 2 months ago

tanishqjasoria commented 2 months ago

Remove additional TouchAndChargeContractCreateInit call before 1/64 gas is deducted
move the TouchAndChargeContractCreateInit call before the collison check and value transfer

gballet commented 2 months ago

~~Fixes 430~~ -> nope, it's a different issue.

gballet commented 2 months ago

As explained in issue 430, this is already fixed in mainnet. I have to check if this is compatible.

jsign commented 2 months ago

As explained in issue 430, this is already fixed in mainnet. I have to check if this is compatible.

@gballet, note that we need to check that CALLs are fixed too before closing #430. This PR is fixing CREATEs.

gballet commented 2 months ago

Yeah I was going through code and realized that this is actually a different issue. I need to remove that, and we have to see if we need to fix the call now as well (probably, as you said).

jsign commented 2 months ago

LGTM but we need to add a test for the collision check. I can make one later.

IIRC, I created test-vectors for collisions (I'll double-check). In any case, any extra geth test is fine too.