Some code cleanup - Githubissues

gballet / multiproof-rs

A rust implementation of Alexey Akhunov's multiproof algorithm

Apache License 2.0

33 stars 8 forks source link

Some code cleanup #37

Closed gballet closed 5 years ago

gballet commented 5 years ago

A series of changes to clean the code up:

Remove the use for NibbleKey::new since From<Vec<u8>> has been implemented;
Rely on hex::decode instead of having a custom function
Change the implementation of display to write the regular data, instead of writing its "debug" version
Remove some comments

I realize that the reason @sina created a custom hex conversion function might have been done with the hope of reducing the size of the final binary. Is that so?

s1na commented 5 years ago

I realize that the reason @sina created a custom hex conversion function might have been done with the hope of reducing the size of the final binary. Is that so?

No, I just didn't know about hex::decode. I then saw it in your code but forgot to change my PR to use it, sorry.

gballet commented 5 years ago

And thank you for cleaning mine ;)