Binary key support + key trait

gballet / multiproof-rs

A rust implementation of Alexey Akhunov's multiproof algorithm

Apache License 2.0

33 stars 8 forks source link

Binary key support + key trait #49

Closed gballet closed 4 years ago

gballet commented 4 years ago

This is preparation work for the support of binary trees.

It introduces a Key trait that will have to be implemented by all objects that can be used as keys;
It introduces BinaryKey that implements Key and represents a bit-wise string;
It rewrites ByteKey and NibbleKey as an implementation of Key; and
it moves ByteKey, NibbleKey and BinaryKey to their own modules.

gballet commented 4 years ago

Based on @s1na's remarks, I have decided to go another route, outlined in #55. Closing this PR.

gballet commented 4 years ago

So after considering the iterator route for some time, and in spite of being convinced that this is the best way in the long run, I also realized it was going to be fairly heavy work, and it's not currently necessary if it's just about not making a couple fields public. I will go ahead with this one in order to resume work on binary trees, and will fix that for the 2.x release.