[Feature request] Temporarily disable shortcuts

gbammc / Thor

Switch the right application ASAP.

MIT License

1.17k stars 69 forks source link

Closed kenji21 closed 4 years ago

kenji21 commented 4 years ago

With Thor, I finally made Function 1-12 keys useful, thanks for this piece of software

Will you be opened to a PR to add a feature in the menubar drop down (like preferences) to be able to disable / enable Thor shortcuts

My use-case is that to configure htop, function keys are needed (but my mapping makes me changing app...)

Today I quit the app, and then relaunch it

gbammc commented 4 years ago

PR is welcome~

kenji21 commented 4 years ago

I'm near ready to PR from https://github.com/kenji21/Thor, but I miss two translations before:

"Disable Shortcuts" = "?";

"Enable Shortcuts" = "?";

gbammc commented 4 years ago

I suggest:

"Disable Shortcuts" = "停用快捷键";

"Enable Shortcuts" = "启用快捷键";

kenji21 commented 4 years ago

❤️

kenji21 commented 4 years ago

should I close this issue or you close it after a new version of the app containing this feature is published ?

gbammc commented 4 years ago

I will close this issue after it is published :)

gbammc commented 4 years ago

It's released in v1.5.2.

kenji21 commented 4 years ago

I don't see any 1.5.2 tags, and checking for updates shows 1.5.0 is the last one (as GitHub does):

Thor 1.5.0 is currently the newest version available.

kenji21 commented 4 years ago

👌