gbaychev / NClass

NClass - the free UML editor, reloaded
GNU General Public License v3.0
172 stars 50 forks source link

Zoom level label displaced in GUI #46

Closed Baltasarq closed 4 years ago

Baltasarq commented 4 years ago

I'm using Manjaro Linux with Mono 6.10. This issue is probably related to Mono/Linux. Very low importance.

As you can see below, the zoom label is misplaced, maybe somehow overflown.

nclass

gbaychev commented 4 years ago

Yes, this is mono specific. Not sure if I can do anything about it, but will check it out.

Baltasarq commented 4 years ago

I wonder if you really need to display that label. For me, is totally accessory.

Baltasarq commented 4 years ago

Okay, I know why this label is being misplaced. Yep it has to do with Mono and its implementation of WinForms.

But more importantly, it has to do with the way the GUI has been built. You've used the designer, and have hard-coded sizes and positions. This means that, if for some reason, any of the components changes it size, then the whole arrangement will fail, since there won't be room for any modification.

But of the whole toolbar, the problem with the toolZoomValue label is that it probably changes its size because it uses a different font in Mono (while icons have all the same size always, of course).

I'd set an specific font and an specific size for that font so this won't happen. For example:

toolZoomValue.Font = new Font( FontFamily.GenericMonospace, 11 );

I guess this can also be set in the designer.

gbaychev commented 4 years ago

Very good catch, I'm a bit curious, why the hell the font changes in mono, but whatever.

Yes, I can fix this, no problem, how's about that: do you want to create your fix and submit a PR? I can put you in the contributors list.

If you have no time/desire, it is also completely fine, just say so.

Baltasarq commented 4 years ago

Yes, I can fix this, no problem, how's about that: do you want to create your fix and submit a PR?

Thanks, I've created a pull request.

I can put you in the contributors list.

Famous at last! ;-)

Baltasarq commented 4 years ago

Fixed now. Thanks!!