nesworld - Githubissues

gbdev / database

JSON database of every Homebrew Hub entries. Propose here additions, improvements and fixes, every change propagates to Homebrew Hub.

https://hh.gbdev.io

Other

82 stars 39 forks source link

nesworld #30

Closed avivace closed 5 years ago

avivace commented 6 years ago

http://www.nesworld.com/article.php?system=gbc&data=gbchomebrew

cwallace3421 commented 5 years ago

I'm interested in taking a look at this. Creating a scraper for nesworld and adding the entries from nesworld. Going to time box this until the end of Friday.

avivace commented 5 years ago

Fantastic! Let me know if need anything

cwallace3421 commented 5 years ago

Making good progress. Got the folders, game.json, screenshots scraped from nesworld. Took a bit longer than expected because the DOM structure on nesworld is terrible 😄. The only small issue is that all of the ROMs are in zip files so working on that at the minute.

I have two quick questions:

On the contribution page it says that at least 1 screenshot is required. But a couple of the ROMs on the nesworld page don't have screenshots available. So should I still include them, or leave them out?
A handful of the ROMs on the nesworld page are classified as applications. They look like mostly music generation and other similar things. Should I still include these ROMs?

avivace commented 5 years ago

Great news!

On the contribution page it says that at least 1 screenshot is required. But a couple of the ROMs on the nesworld page don't have screenshots available. So should I still include them, or leave them out?

Include them! If there are only some entries we add the screenshots manually

A handful of the ROMs on the nesworld page are classified as applications. They look like mostly music generation and other similar things. Should I still include these ROMs?

If there is consistent interaction it's a "typetag" : "homebrew", otherwise "typetag" : "demo"

tobiasvl commented 5 years ago

Leave them! If there are only some entries we add the screenshots manually

You mean "include them"! @cwallace3421 asked to "include them" or "leave them out", and you probably didn't mean the latter 😂

avivace commented 5 years ago

@tobiasvl Woops, brainlag. Yep, yep. You're right.

avivace commented 5 years ago

@cwallace3421 Any update on this?

cwallace3421 commented 5 years ago

Been super busy, sorry! I'm pretty much finished with it just need to get it all packaged up for a pull request. Should have time this week and I'll get it done.

avivace commented 5 years ago

@cwallace3421 Ping! It's okay even if it's unfinished, if you don't have time, don't worry

cwallace3421 commented 5 years ago

Finally found the time and I have finished it up! I created a pull request with everything in it. If anything is wrong with it give me a shout 🙂

avivace commented 5 years ago

Thank you for taking the time for this. Brilliant job! Will look into it now.

avivace commented 5 years ago

58da001349dca95bb1f31f9e4b0351bf48f0b262 merged the scraper. The actual entries merge is blocked by #35 , https://github.com/gbdev/database/pull/39#pullrequestreview-181427692 and #41

avivace commented 5 years ago

Aaaand we did it :tada: The result of your work was finally merged and everything should be live. Let me thank you again for sticking with me and for coping with the number of other changes I implemented while you were working on the scraper.