Closed avivace closed 5 years ago
I'm interested in taking a look at this. Creating a scraper for nesworld
and adding the entries from nesworld
.
Going to time box this until the end of Friday.
Fantastic! Let me know if need anything
Making good progress. Got the folders, game.json, screenshots scraped from nesworld. Took a bit longer than expected because the DOM structure on nesworld is terrible 😄. The only small issue is that all of the ROMs are in zip files so working on that at the minute.
I have two quick questions:
Great news!
On the contribution page it says that at least 1 screenshot is required. But a couple of the ROMs on the nesworld page don't have screenshots available. So should I still include them, or leave them out?
Include them! If there are only some entries we add the screenshots manually
A handful of the ROMs on the nesworld page are classified as applications. They look like mostly music generation and other similar things. Should I still include these ROMs?
If there is consistent interaction it's a "typetag" : "homebrew"
, otherwise "typetag" : "demo"
Leave them! If there are only some entries we add the screenshots manually
You mean "include them"! @cwallace3421 asked to "include them" or "leave them out", and you probably didn't mean the latter 😂
@tobiasvl Woops, brainlag. Yep, yep. You're right.
@cwallace3421 Any update on this?
Been super busy, sorry! I'm pretty much finished with it just need to get it all packaged up for a pull request. Should have time this week and I'll get it done.
@cwallace3421 Ping! It's okay even if it's unfinished, if you don't have time, don't worry
Finally found the time and I have finished it up! I created a pull request with everything in it. If anything is wrong with it give me a shout 🙂
Thank you for taking the time for this. Brilliant job! Will look into it now.
58da001349dca95bb1f31f9e4b0351bf48f0b262 merged the scraper. The actual entries merge is blocked by #35 , https://github.com/gbdev/database/pull/39#pullrequestreview-181427692 and #41
http://www.nesworld.com/article.php?system=gbc&data=gbchomebrew