search

gbdev / gb-asm-tutorial

Learn to create games for the Game Boy using Assembly
http://gbdev.io/gb-asm-tutorial/
MIT License
108 stars 38 forks source link

Possible typo in Jumps #3

Closed wooster0 closed 3 years ago

wooster0 commented 3 years ago

From https://eldred.fr/gb-asm-tutorial-v2/part1/jumps.html#conditional-jumps:

ld bc, Tiles.end - Tiles sets bc to the length of the tile data: Tiles.end is the address of the first byte after the tile data, so subtracting Tiles to that yields the length.

Tiles.end should probably be TilesEnd. I couldn't find this source in this repository so I wasn't able to submit a PR.

ISSOtm commented 3 years ago

Yeah, it is. I'm currently working on v2, though, so this is a wontfix ^^

meithecatte commented 3 years ago

The issue is in the v2, though

ISSOtm commented 3 years ago

Ah, I didn't notice because of the repo.

ISSOtm commented 3 years ago

Fixed locally, closing. Thanks!