search

gbdev / gb-asm-tutorial

Learn to create games for the Game Boy using Assembly
http://gbdev.io/gb-asm-tutorial/
MIT License
116 stars 41 forks source link

Galactic Aramada Charmap Mapping Issue #78

Closed walshyb closed 9 months ago

walshyb commented 9 months ago

Issue

In Galactic Armada, letters after "n" in the text macro charmap are offset by 1 because the there isn't a title dedicated to "O", it is shared with "0" at position 10.

This makes it so when you load the game, instead of "PRESS A TO PLAY" under the title, you see "QSETT A UP QLAZ".

Output upon starting game:

image

Steps to reproduce

  1. Clone gb-asm-tutorial repo
  2. Change directory to galactic-armada
  3. Run make
  4. Open the GalacticArmada.gb file with your emulator of choice.

Credit

Shout out to pichu___. on the gbdev Discord for helping find and solve the issue!

walshyb commented 9 months ago

Actually, issue was with my local setup! Accidentally created a tilemap alongside the text-font.2bpp, and when doing so it was also modifying the .2bpp somehow, making it so the tiles would be missing 1 tile (the "o").

I was getting this:

image



Should look like this: image

ISSOtm commented 9 months ago

Ah, good then; AIUI then there's nothing to be fixed on our end?

walshyb commented 9 months ago

Correct! I think it was all on my end. Good to close