Replace logo with smaller PNG and add "pocket"

ISSOtm commented 5 years ago

The console's overall design is a Pocket's, basically.

The PNG is only 1k, the font is 10k for just these few chars, that felt kinda overkill. (And, besides, adding "Pocket" was going to require a PNG.)

I don't have Node on my computer, so let's just hope this works, otherwise I'll have to make fix commits...

torch2424 commented 5 years ago

@ISSOtm Nice catch with the file sizes! 😄

I can't test this out till later. Though I definitely think we should test this before merging.

avivace commented 5 years ago

I'm not going to review another PR like this again. I've looked into this because you pinged multiple times. You didn't even tried to deploy your edits, nor copy paste the build instructions to see if the PR made sense. The build wasn't ready to handle the Game Boy animation importing something like compass and we were previously importing the "built" animation, directly in the main.styl. The gameboy.scss file you were editing wasn't even imported.

The PNG in the PR was horrible so I used the last one you posted on Discord. It looks good.

I had to do things from 6426c58da3d0b3d311320a1ed1cb55170ce2493b all the way up to 2064ab6c5e50a8fa59bf8b0fe38234a263b725b0 to make this work. Most of these things were needed anyway, but still, that's why I was rejecting the PR.

Just to be clear: I'm still not conviced about this:

We could have used 'Cabin' as body font, and remove 'Cairo'. This way we'd avoid to load a third font.
The pocket part was never going to require a PNG. It can be easily achieved with italic bond Cabin, a background color to simulate the "highlight" effect and a slightly smaller font-size.
This removes the possibility to make the animation larger and possibily scale with screen resolutions.
Gill Sans, the original font used in the Game Boy logo, and Cabin, our free alternative, are basically indentical in our context. Also, Gill Sans is in OS X and Microsoft Office, so we would fall back to Cabin only when Gill Sans wasn't already available.

For now this is on master, I may reconsider/re open this.

ISSOtm commented 5 years ago

Yes, I understand. I shouldn't have rushed it like that.

(I'm not sure how the build system works, though?)

As for the responsiveness issue, I've tried fiddling with the animation to replace the fixed (px) units with scalable ones (%), and it's just broken. It seems pretty daunting to make this scale, at least afaik.

gbdev / gbdev.github.io

Replace logo with smaller PNG and add "pocket" #1