Continue SGB border - Githubissues

gbdev / gbdev.github.io

the 'game boy development community' institutional website: showcases projects and hosts some community content

https://gbdev.io

GNU General Public License v3.0

23 stars 11 forks source link

Continue SGB border #71

Closed pinobatch closed 11 months ago

pinobatch commented 11 months ago

PR #70 ended with different suggested changes stomping on one another. Finish the last few tasks mentioned in that PR's discussion.

fix a comma splice
explain why wait 4 frames
emphasize why the screen must be on
use line comments (;) instead of C block comments (/*...*/)
transform detection code into a subroutine to eliminate .init
rewrite detection code to use a busy wait loop instead of vblank interrupt
let the lines settle after each read in case A+Right held on DMG
store the detection result to a variable
Remove mention of use of palettes 1-3 and 7

avivace commented 11 months ago

Thanks a lot @pinobatch , I'll start merging it