search

gbdev / hardware.inc

RGBDS include file for Game Boy hardware definitions
Creative Commons Zero v1.0 Universal
119 stars 21 forks source link

Register ordering, byte-based sizes, OAM additions, general cleanup #4

Closed BlitterObjectBob closed 4 years ago

BlitterObjectBob commented 5 years ago

I'm not a fan of the 'o'-named register EQUs (for offset), but couldn't think of anything else.

BlitterObjectBob commented 4 years ago

I have a local change (not committed yet) related to the bootup values:

;***************************************************************************
;*
;* CPU values on bootup (a=type, b=qualifier)
;*
;***************************************************************************

BOOTUP_A_DMG    EQU $01 ; Dot Matrix Game
BOOTUP_A_CGB    EQU $11 ; Color GameBoy
BOOTUP_A_MGB    EQU $FF ; Mini GameBoy (Pocket GameBoy)

; if a=BOOTUP_A_CGB, bit 0 in b can be checked to determine if real CGB or
; other system running in GBC mode
BOOTUP_B_CGB    EQU %00000000
BOOTUP_B_OTHER  EQU %00000001   ; GBA, GBA SP, Game Boy Player, or New GBA SP

Thoughts on including this in the PR? Thoughts in general?

BlitterObjectBob commented 4 years ago

I've included them (plus OAM changes) in the PR for commenting there.

BlitterObjectBob commented 4 years ago

Bump :)

mid-kid commented 4 years ago

Suggestion: BOOTUP_B_OTHER -> BOOTUP_B_AGB, because you can summarize all of the GBA platforms with that.

avivace commented 4 years ago

Wow, this went a long way. I like the changes.

Thank you for sticking with this, @BlitterObjectBob and @ISSOtm !