gbdev / hardware.inc

RGBDS include file for Game Boy hardware definitions
Creative Commons Zero v1.0 Universal
119 stars 21 forks source link

Update hardware.inc #6

Closed daid closed 4 years ago

daid commented 4 years ago

The pandocs list these bits in rNR52 as read only. And the oracle games seem to read these back to check if sound is done.

I think these "does not work" comments came from the fact that writing to them does nothing.

ISSOtm commented 4 years ago

Or it might be referring to the fact that they only indicate the state of the channel's generation circuit and not the DAC. Hard to tell from something this vague... This change is still welcome, imo. We may make it more nuanced if necessary, but that's probably a better fit for actual docs.