gbdev / homebrewhub

A digital repository of of homebrews, patches, hackroms for old consoles. Provides community submission, tagging and rating features.
https://hh.gbdev.io
GNU General Public License v3.0
46 stars 9 forks source link

Comment API status #10

Closed avivace closed 6 years ago

avivace commented 6 years ago

Aight, this wasn't as trivial as we expected, since a lot more factors appeared while implementing the basic routes.

I guess we need to do this the long way round: I propose to stop the development here and move to a separate module.

Priorities are:

We could then proceed to decide on stateful actions (backend side):

Does this makes sense to you, @dennib ?

dennib commented 6 years ago

As discussed yesterady I will continue the development on comment-api branch, we should be close to a basic functional version of "Comment System"

dennib commented 6 years ago

Update:

Still missing correct visual behavior for the moment a comment has been added, I will continue there and then I'll focus on /edit/ route.

Every bit of comment system on "old" routes.js file should be useless now, I'll check and confirm (also removing those parts) later

avivace commented 6 years ago

Gotcha. Confirm that everything I removed on routes was just backend/sync rendering so we can go completely async with the API endpoints you mentioned

dennib commented 6 years ago

Ok I checked, I can confirm! Those parts are not needed anymore (or they are rewritten elsewhere). Comment System functionalities are now completely async with the use of API endopoints mentioned above (for which I still have to write the wiki documentation :P)

dennib commented 6 years ago

Update:

I'm ready to merge :)

avivace commented 6 years ago

Nicely done. Go ahead.

Feel free to open a PR if you need help in solving merge conflicts.