search

gbdev / homebrewhub

A digital repository of of homebrews, patches, hackroms for old consoles. Provides community submission, tagging and rating features.
https://hh.gbdev.io
GNU General Public License v3.0
44 stars 9 forks source link

Update sync_db script location and updated README instructions #86

Closed rnegron closed 1 year ago

rnegron commented 1 year ago

The instructions for running sync_db were not working since runscript expects to find scripts in a script/ folder at the root of the directory! Updated the README with the flow that worked for me when setting up locally.

I also tweaked the script (just a little bit) to reduce some lines.

rnegron commented 1 year ago

@avivace Hello! I have a couple of PRs that I'd like to contribute, particularly for updating the dev experience of this project (pre-commit, tests, etc.). Let me know if there's something you don't like since I'm going off my own preferences with Django projects.

Also wanted to ask how far is too far with changes, for example I would love to add created_at and updated_at fields for the Entry model but that would imply a complex migration. Any way you could share how this project is being deployed and such?

avivace commented 1 year ago

@avivace Hello! I have a couple of PRs that I'd like to contribute, particularly for updating the dev experience of this project (pre-commit, tests, etc.). Let me know if there's something you don't like since I'm going off my own preferences with Django projects.

Also wanted to ask how far is too far with changes, for example I would love to add created_at and updated_at fields for the Entry model but that would imply a complex migration. Any way you could share how this project is being deployed and such?

Hi! That would be awesome! Feel free to propose and send PRs and we can directly discuss then!

I'm pretty open with changes, especially considering that the database building and populating phases are completely reproducible from the git repository, so we wouldn't even need to really migrate, just re rerun the database creation.

Did you try to follow the documentation and deploy it locally? (this is also a great chance to review the instructions and see how can we improve them)

rnegron commented 1 year ago

This closes #54 I believe