gbdev / pandocs

The single, most comprehensive Game Boy technical reference.
https://gbdev.io/pandocs/
Creative Commons Zero v1.0 Universal
593 stars 92 forks source link

Failing to commit #1

Closed avivace closed 2 years ago

avivace commented 4 years ago

Sometimes, the script is giving "nothing to commit" but I can't track down the Issue.. E.g. revisions 160 and 179 are having this behaviour

avivace commented 4 years ago

160 and 179 diff

pandoc is (correctly) escaping and ignoring mediawiki {{}} meta links so the output is the same and git refuses to git add.

We good. Still have to check if that is the case for all the ~15 commits we are missing (total ~210 revisions, but ~190 commits generated)

RetroEdit commented 3 years ago

First thing I'll note: the {{ }} syntax is called 'transclusion' in the wikitext vernacular, and the pages they refer to are generally pages in the template namespace (you can also transclude other pages with the same syntax, but I won't get into that).

Without further details, it's difficult to tell definitively whether all the revisions where git refused to add were the template transclusion commits. I might have a try at running the script and seeing if it has problems on those specific revisions, but it's somewhat inconvenient that it does git operations for each revision.

What I've noticed with pandoc is that it will insert something like the following when a template is missing (with backtick triplets before and after the section, which I can't really show in a Github comment):

{=mediawiki}

{{Pandocs|spriterambug}}

This might just be an artifact of me running the script multiple times or possibly something else different with my environment.

Here's a list of wiki edits I found just from browsing wiki edits of one contributor who was adding the template transclusions: 166, 167, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184

When I run the script and just look at the file differences, I'm also getting some other odd things with those specific revision ids, so I'll probably need to look into that further too.