gbdev / pandocs

The single, most comprehensive Game Boy technical reference.
https://gbdev.io/pandocs/
Creative Commons Zero v1.0 Universal
618 stars 93 forks source link

MBC7 Rumble #575

Open dcerchia opened 1 month ago

dcerchia commented 1 month ago

In 16. The Cartridge Header, 0147-Catridge type, the table lists code $22 as MBC7+SENSOR+RUMBLE+RAM+BATTERY.

Page 17.7 MBC7 doesn't mention rumble, none of the official MBC7 games support rumble, and I couldn't find any reliable source on the internet of MBC7 supporting rumble.

So, I think either RUMBLE should be removed from $22 in the Cartridge Type table, or at least a note should be made about it somewhere since MBC7 isn't fully tested.

bbbbbr commented 2 weeks ago

Looks like it might have been copied from the 0x1E entry. https://github.com/gbdev/pandocs/commit/6c3b4f4d5075424254088463dc0b2f41b99114a3

This could be an alternative description, noting that it also doesn't have RAM and a battery (from what I gather): MBC7+ACCELEROMETER+EEPROM

dcerchia commented 2 weeks ago

Thanks for checking it out. Yeah, I think that description makes more sense.