search

gbdev / rgbds-live

A live Gameboy programming environment in the browser, allowing for realtime assembly programming for the gameboy.
https://gbdev.io/rgbds-live/
MIT License
36 stars 8 forks source link

RFC: How to maintain binjgb changes ? #9

Closed avivace closed 11 months ago

avivace commented 12 months ago

rgbds-live requires a modified version of the binjgb emulator, currently in a fork by Daid. @surma raised an interesting point about how those changes should be mantained.

Some alternatives:

  1. Re-fork from Daid's binjgb under the gbdev org
    • This requires periodically rebasing against binji's upstream so we don't diverge
  2. Maintain the changes as patches
    • This requires manual work to update the patches when upstream changes (see what we already have to do for the RGBDS patch which breaks every time)
  3. Discuss with @binji and see if we could PR them directly into upstream
binji commented 12 months ago

There aren't a lot of changes, I can push them upstream. Not quite as-is, since it would break other builds, but I can take a look.

binji commented 11 months ago

Changes landed upstream. You can pass -DRGBDS_LIVE to the build to enable the additional features.

avivace commented 11 months ago

Amazing, thanks @binji !