gbdev / rgbds-www

RGBDS website, hosting documentation and install instructions. Built with Docusaurus, content from RGBDS man pages.
https://rgbds.gbdev.io
Other
7 stars 7 forks source link

rgbds.gbdev.io sitemap can't be submitted to google #25

Closed avivace closed 3 years ago

avivace commented 3 years ago

Apologies if this is not the correct place to report errors on the generated website/documentation.

This is what I'm seeing on the Google Webmaster console for rgbds.gbdev.io:

image

ISSOtm commented 3 years ago

Transferred to the website repo, no worries :p

Yeah, I tried submitting the sitemap some time ago, and it failed for the same reason—I've forgotten since then. I'm not quite sure why it's failing, though. The sitemap is automatically generated, too.

pinobatch commented 3 years ago

I'm pretty sure /docs/ failed because it's an origin-relative URL, not an absolute URL. From General sitemap guidelines:

Use consistent, fully-qualified URLs. Google will crawl your URLs exactly as listed. For instance, if your site is at https://www.example.com/, don't specify a URL as https://example.com/ (missing www) or ./mypage.html (a relative URL).

ISSOtm commented 3 years ago

To try: set the URL config properties, see if the sitemap generator picks them up.

https://github.com/gbdev/rgbds-www/blob/9c688a50847c96a90e5c3067a1a7c07cbe47afa4/_config.yml#L16-L17

ISSOtm commented 3 years ago

... with these settings, my sitemap on localhost properly contains absolute URLs, so this is likely not it... I just updated the gems, though, so we'll see if those updates fix the issue.

ISSOtm commented 3 years ago

... nope, so I'll try setting them real quick. It's imo likely that GitHub overrides those somehow, causing the truncated URLs to appear.

ISSOtm commented 3 years ago

... nope. I reverted the commit (a quick force-push on this repo won't hurt anyone), but at this point we may have to report an issue to GitHub themselves—this doesn't seem to be on our side.

ISSOtm commented 3 years ago

We just have to wait and see now.

ISSOtm commented 3 years ago

Fixed by 0c9b420 :)

image

avivace commented 3 years ago

Great! Thanks @ISSOtm