search

gbdev / rgbds-www

RGBDS website, hosting documentation and install instructions. Built with Docusaurus, content from RGBDS man pages.
https://rgbds.gbdev.io
Other
7 stars 8 forks source link

[Enhancement] Providing alternative styles #4

Closed ISSOtm closed 2 years ago

ISSOtm commented 4 years ago

We could provide alternative styling, for example modifying the font size, providing a dark mode, and disabling text justification (I was told dyslexic people have trouble with it). Additionally, it should be possible to use prefers-color-scheme to set the default color scheme, for example.

There are two problems:

  1. How can we store this information at least during one browsing session? True persistence is probably not worth implementing, but it'd just be frustrating to have to reset these settings for every visit.
  2. How do we provide toggles? Adding them to the navbar would increase the clutter, especially on mobile; plus, managing the drop-downs with the collapsed navbar would add complexity...

Problem 1 could be solved using some JS and browser storage, as I've seen some sites do. For Problem 2, I'm thinking we could add some button at the bottom of the page, that'd open a drop-down/pop-up of toggles?

zemzelett commented 2 years ago

I'm working on this atm, is there any preference on a dark-mode color scheme other than mentioned in issue #14?

Oh, and for your points on the problems: I'd solve problem 1 with Local Storage. Problem 2 i'd solve along the lines of what you pointed out.

ISSOtm commented 2 years ago

Ah, we are currently working on a complete overhaul of the site over at rgbds-www2, which does have dark mode support. This is where contributions should happen now, besides important fixes that shouldn't wait.

zemzelett commented 2 years ago

Ha, thanks for the heads up. Luckily i didn't do too much yet. :)

avivace commented 2 years ago

Closed in favor of https://github.com/gbdev/rgbds-www/issues/27, which already includes a dark mode.