search

gbdev / rgbds

Rednex Game Boy Development System - An assembly toolchain for the Nintendo Game Boy and Game Boy Color
https://rgbds.gbdev.io
MIT License
1.35k stars 172 forks source link

[UX] Linker error when using old object files is unclear #1118

Closed aaaaaa123456789 closed 1 year ago

aaaaaa123456789 commented 1 year ago

At least as seen from the perspective of an unexperienced user.

\<file> is a revision 0xNNNN object file; only 0xRRRR is supported

For a newbie user, this error might as well say "something went wrong". Maybe improve it by suggesting rebuilding the file or something?

ISSOtm commented 1 year ago

" is a revision 0xNNNN object file, only 0xRRRR is supported; try rebuilding with an older/newer version of RGBDS"?

aaaaaa123456789 commented 1 year ago

You're giving useless information to the user from the beginning. Revision numbers aren't a user-visible feature. "xxxx.o cannot be linked because it was built with a different version of RGBDS; try rebuilding your project. (Expected revision 42, got 69.)"

aaaaaa123456789 commented 1 year ago

This would've been handled by #1119, but the PR was closed unmerged due to deletion of the containing repo. Just leaving a note here.