Refer to "end of line", not "newline"

gbdev / rgbds

Rednex Game Boy Development System - An assembly toolchain for the Nintendo Game Boy and Game Boy Color

https://rgbds.gbdev.io

MIT License

1.33k stars 171 forks source link

Refer to "end of line", not "newline" #1517

Closed Rangi42 closed 1 week ago

Rangi42 commented 1 week ago

Fixes #1514

Rangi42 commented 1 week ago

Calling it "end of file" would sometimes result in error messages saying "expected end of file or end of file". Calling it "end of input" sounds to me like the end of all the input, not just some inner buffer. Though I agree "buffer" is a technical term, would be nice to have a better one. (What exactly are they for? The end of INCLUDEd files? Expanded EQUS and/or {interpolations}` and/or macro args? Maybe "end of included file" or "end of expanded string" would be good?)

ISSOtm commented 1 week ago

It's for the end of included files.

Rangi42 commented 1 week ago

It's for the end of included files.

Apparently it's also for the end of REPT/FOR and MACRO bodies.

Rangi42 commented 1 week ago

Let's leave potentially renaming EOB for another PR?