search

gbdev / rgbds

Rednex Game Boy Development System - An assembly toolchain for the Nintendo Game Boy and Game Boy Color
https://rgbds.gbdev.io
MIT License
1.35k stars 172 forks source link

OPT_CONTWRAM was not meant to restrict VRAM banking #166

Closed PikalaxALT closed 7 years ago

PikalaxALT commented 7 years ago

The only reason why I added OPT_CONTWRAM was to allow for a continuous 2000h-byte WRAM section. A recent commit reappropriates this flag, renamed OPT_DMG_MODE, to also disable VRAM banking. However, there are several titles that have DMG wram behavior but take advantage of CGB functions such as 1:9800-9fff (bg attributes).

Furthermore, this version breaks Robopon.

AntonioND commented 7 years ago

You can't seriously expect me to know every single way this is being used. This change just made sense, but don't worry, I'll revert this. Things in development break, but I think I've been pretty reasonable untill now, taking care of the needs of you disassemblers (yes, I don't break your code on purpose) and fixing some old issues, and even finding bugs in poorly organised code that I didn't write (pokered anyone?).

I'll just create a new flag that enables the continuous WRAM flag and prohibits VRAM bank 1.

And yes, I'm talking about this: https://github.com/rednex/rgbds/commit/e3109af2f8943ea410b2ace30cc57d7b6f04ea25#commitcomment-21694122

And remember that you wanted to break old code as well, and you knew that you were breaking it: https://github.com/rednex/rgbds/pull/95

AntonioND commented 7 years ago

Fixed in https://github.com/rednex/rgbds/commit/5679c7066b0f7365f0696fd07f539e5b9dd82a7d