search

gbdev / rgbds

Rednex Game Boy Development System - An assembly toolchain for the Nintendo Game Boy and Game Boy Color
https://rgbds.gbdev.io
MIT License
1.35k stars 172 forks source link

2 issues with release source tarball #924

Closed rofl0r closed 3 years ago

rofl0r commented 3 years ago

1) it's convention to have a tarball extract to a directory of the same name - rgbds-0.5.1.tar.gz should extract to "rgbds-0.5.1", not "rgbds"

2) the source tarball is a lot bigger than the distributed binaries, because it contains 11MB of binary tests. i suppose those could be omitted.

ISSOtm commented 3 years ago

For point 1, it's standard for the rest of programs, I understand that, but we've been using rgbds/ for a while, so I believe it's better to stay consistent with our previous releases (for uniformity) than to switch to adhering to that convention.

The source tarballs include tests because some distros like testing software they build; I believe it helps ensure the stability of custom build options and patches.

Rangi42 commented 3 years ago

For point 1, it's standard for the rest of programs, I understand that, but we've been using rgbds/ for a while, so I believe it's better to stay consistent with our previous releases (for uniformity) than to switch to adhering to that convention.

As long as there's a subdirectory, IMO it's fine, be it name or name-version.