search

gbdev / virens

Homebrew Hub web frontend, in Nuxt 3. Powered by webassembly builds of binjgb and mGBA.
https://hh.gbdev.io
GNU General Public License v3.0
18 stars 1 forks source link

"Improve metadata for this entry" always links to GB instead to GBA entries #36

Closed tolik518 closed 1 year ago

tolik518 commented 1 year ago

A homebrew page has a "Improve metadata for this entry" link that should link to the page with the metadata. This works only for GB games though, not for GBA games.

On the page of Butano Fighter for example it links to github.com/gbdev/database/tree/master/entries/butano-fighter/game.json instead of to github.com/gbadev-org/database/tree/master/entries/butano-fighter/game.json

avivace commented 1 year ago

Thanks for the report @tolik518 ! Unfortunately the support for additional "data sources" is still a bit premature and I merged it before taking care of adapting the database schema for this, so atm the API doesn't really know from which upstream repository any entry is from (and frontend just default-guesses the gbdev/database one), the sync script must also be adapted for this. I already reported this in https://github.com/gbdev/homebrewhub/issues/95 so I'm going to close this as duplicate but I plan to take care of it soon (tm).