Closed chrismaltby closed 8 months ago
This is amazing! Appreciate you figuring out how to get it working and PRing the support.
Does updating the intel Mac runner to macos-13
from macos-11
will have any impact on OS compatibility. I don't know enough about the platform to understand how the export MACOSX_DEPLOYMENT_TARGET=10.10
setting interacts with potential changes in target OS support in the toolchain on 13.
Although if the older runners often aren't able to complete their build anymore due to the homebrew changes, then maybe my question is kind of a moot point. :sweat_smile:
Let's leave the Intel Mac cc1
build fix as is for now.
Happy to help :-)
I forgot to mention yes I'd tested this on an Intel Mac running 10.14.5 and it's still working as expected. Not really sure how the MACOSX_DEPLOYMENT_TARGET
env variable changes things myself either but looks like moving from macOS 11 to macOS 13 didn't break support for macOS 10.x from what I can see
Perfect, thanks! Merging :)
I'm working on updating GB Studio to support M1/M2/M3 Macs natively, noticed that the gbdk-2020 main repo fetches sdcc builds from this repo so just wanted to add Mac arm64 support (I can make a PR into gbdk-2020 main repo if you're happy with this change)
macos-14
runners so I've added that to the matrix https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available//opt/homebrew
) so I've had to set LDFLAGS and CPPFLAGS just for macos-14boost
libraries on macos-11 at some point very recently so it was trying to compile from source adding 30 minutes to the build time for Mac x64 which would 50/50 chance timeout. The fix was to update to usingmacos-13
for the x64 build which was the last macOS that GitHub actions uses Intel based runners formacos-13
then introduced an issue where homebrew tried to install python3 after completing the brew install step and was clashing with a version already installed by the os, the fix for this was to set the environment variableHOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK=1
You can see the result of running this updated action here https://github.com/chrismaltby/gbdk-2020-sdcc/actions/ I've rebuilt GBDK-2020 using the SDCC build from running these actions and all seems to be working, I've also tested this running builds from GB Studio.