gbif / checklistbank

GBIF Checklist Bank
Apache License 2.0
31 stars 14 forks source link

clb-registry-cli fails to delete #227

Open mdoering opened 2 years ago

mdoering commented 2 years ago

the registry-cli is supposed to listen to deleted datasets and remove them from ES and postgres. The prodcrawler1 logs show an error when we deleted https://www.gbif.org/dataset/d8fb1600-d636-4b35-aa0d-d4f292c1b424

INFO  [2022-10-12 08:09:07,615] [clb-registry-change-1] org.gbif.checklistbank.cli.registry.RegistryService [d8fb1600-d636-4b35-aa0d-d4f292c1b424] Deleting data for checklist d8fb1600-d636-4b35-aa0d-d4f292c1b424
ERROR [2022-10-12 08:09:07,622] [clb-registry-change-1] org.gbif.checklistbank.cli.registry.RegistryService [d8fb1600-d636-4b35-aa0d-d4f292c1b424] Failed to delete dataset with key [d8fb1600-d636-4b35-aa0d-d4f292c1b424] from search index
java.lang.RuntimeException: co.elastic.clients.util.MissingRequiredPropertyException: Missing required property 'DeleteByQueryRequest.index'
        at org.gbif.checklistbank.index.NameUsageIndexServiceEs.deleteDataset(NameUsageIndexServiceEs.java:184)
        at org.gbif.checklistbank.cli.registry.RegistryService.delete(RegistryService.java:124)
        at org.gbif.checklistbank.cli.registry.RegistryService.handleMessage(RegistryService.java:157)
        at org.gbif.checklistbank.cli.registry.RegistryService.handleMessage(RegistryService.java:49)
        at org.gbif.common.messaging.MessageConsumer.handleCallback(MessageConsumer.java:129)
        at org.gbif.common.messaging.MessageConsumer.handleDelivery(MessageConsumer.java:82)
        at com.rabbitmq.client.impl.ConsumerDispatcher$5.run(ConsumerDispatcher.java:149)
        at com.rabbitmq.client.impl.ConsumerWorkService$WorkPoolRunnable.run(ConsumerWorkService.java:104)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:750)
Caused by: co.elastic.clients.util.MissingRequiredPropertyException: Missing required property 'DeleteByQueryRequest.index'
        at co.elastic.clients.util.ApiTypeHelper.requireNonNull(ApiTypeHelper.java:76)
        at co.elastic.clients.util.ApiTypeHelper.unmodifiableRequired(ApiTypeHelper.java:141)
        at co.elastic.clients.elasticsearch.core.DeleteByQueryRequest.<init>(DeleteByQueryRequest.java:174)
        at co.elastic.clients.elasticsearch.core.DeleteByQueryRequest.<init>(DeleteByQueryRequest.java:68)
        at co.elastic.clients.elasticsearch.core.DeleteByQueryRequest$Builder.build(DeleteByQueryRequest.java:1128)
        at co.elastic.clients.elasticsearch.core.DeleteByQueryRequest$Builder.build(DeleteByQueryRequest.java:568)
        at co.elastic.clients.elasticsearch.ElasticsearchClient.deleteByQuery(ElasticsearchClient.java:580)
        at org.gbif.checklistbank.index.NameUsagesEsIndexingClient.deleteByDatasetKey(NameUsagesEsIndexingClient.java:60)
        at org.gbif.checklistbank.index.NameUsageIndexServiceEs.deleteDataset(NameUsageIndexServiceEs.java:181)
        ... 10 common frames omitted
INFO  [2022-10-12 08:09:07,623] [clb-registry-change-1] org.gbif.checklistbank.service.mybatis.service.UsageSyncServiceMyBatis [d8fb1600-d636-4b35-aa0d-d4f292c1b424] Deleting entire dataset d8fb1600-d636-4b35-aa0d-d4f292c1b424
INFO  [2022-10-12 08:09:07,954] [clb-registry-change-1] org.gbif.checklistbank.cli.registry.RegistryService [] Deleted dataset storage files
08
mdoering commented 2 years ago

Postgres data has been successfully removed, it is just in Elastic now