search

gbif / gbif-api

GBIF API
Apache License 2.0
27 stars 5 forks source link

Extend Rank enum with ZooBank ranks #7

Open mdoering opened 7 years ago

mdoering commented 7 years ago

ZooBank as the zoological nomenclator contains a few very rare ranks that we should nevertheless add to our rank enumeration:

altera: Cyclopterus liparis altera minor Fabricius, 1780

type: Serrivomer sector type brevidentatus Roule & Bertin, 1929 -> Serrivomer sector typ. longidentatus Roule & Bertin, 1929

facies: Salmo trutta major facies rhodanensis Roule, 1923

MattBlissett commented 7 years ago

If I remember correctly, IPNI contains about 500 ranks...

kbraak commented 7 years ago

Please also keep the IPT rank vocabulary in mind when making changes: http://rs.gbif.org/vocabulary/gbif/rank_2015-04-24.xml Thanks

mdoering commented 7 years ago

The IPT rank vocabulary is already far outdated as you can quickly see by the last commmits to the rank enum: https://github.com/gbif/gbif-api/commit/3826c67276b18dbaf1eae6b35e7334360bf3b9a5#diff-aa13cc02e499b7a41c36fc3741978912

If we need to keep the 2 in sync I would suggest that there is an IPT unit test that makes sure all enum values are in that list

mdoering commented 7 years ago

@MattBlissett are these IPNI ranks exposed anywhere? 500 is pretty bad

MattBlissett commented 7 years ago

There's a bit of background on http://www.ipni.org/understand_the_data.html, I think there's some data against them to assign them to a better-known rank, but I don't remember the details.

There's no list exposed anywhere.