search

gbif / gbif-api

GBIF API
Apache License 2.0
27 stars 5 forks source link

Adds SUPERDOMAIN for https://github.com/gbif/pipelines/issues/850 #99

Closed timrobertson100 closed 1 year ago

mdoering commented 1 year ago

When adding a new rank to the API enum and adopting that version in CLB we also need to update the postgres enum. ES appears to use string keywords, so no need to reindex.

More generally we are dealing with 2 rank enumerations. The GBIF API one here and the name parsers native enum which is ahead of the GBIF one and contains many more ranks - but not yet the superdomain one.

A clear policy of keeping both in sync, keeping them separate but maintain a mapping or replacing one with the other would be good. COL CLB uses the name parsers rank enum directly.

I don't see any immediate harm in adding superdomain to the API, but if we do so I would rather update the enum with all missing ranks.

timrobertson100 commented 1 year ago

OK - it does seem a better option to have that fixed up instead