gbif / gbif-common

Utility classes
Apache License 2.0
1 stars 1 forks source link

TabularDataFileReader read method should throw ParseException #11

Closed cgendreau closed 6 years ago

cgendreau commented 6 years ago

Currently, TabularDataFileReader's read method only throws IOException but if a line can be read correctly but can't be parsed (the only example I know is when quoting is used) a RuntimeException is thrown. This is problematic for other projects (e.g. the gbif-data-validator) since the exception is too general.

The suggestion is to change the read method to also throw java.text.ParseException.

MattBlissett commented 6 years ago

I merged this yesterday, thanks Christian!