gbif / gbif-web

Apache License 2.0
6 stars 9 forks source link

inline faq items #527

Closed MortenHofft closed 1 month ago

MortenHofft commented 1 month ago

For gbif.org we added the option for editors to be able to link to faq items with an inline parameter that would mean that instead of the link a modal would be shown with the content.

Example: https://www.gbif.org/article/6S38ZH4I85kHGHkBvpa02y/bid-2020-frequently-asked-questions on some pages like above it is essentially all the page

On the current site, the html is generated servers ide and angular attach in the browser. That version is less ideal for our new site.

idea for implementation

The latter appeals most to me as I would also like to see preview cards elsewhere. It is a part of the radix ui/shadcn library we are using already. For the faq items, we probably cannot use that though, but we could then use the underlying library which is the omnipresent floating-ui and make a non-react implementation with that (mostly just to avoid adding more kb than neccessary)

Either way - the site will work even without this functionality (since the links works fine), so I'm comfortable leaving it for later

MortenHofft commented 1 month ago

I'm going to close this. It isn't perfect, but we have more important stuff to do. We can revisit this if comms finds that it isn't good enough.