search

gbif / geocode

Geocode webservice and client
Apache License 2.0
4 stars 4 forks source link

Gadm search #13

Closed fmendezh closed 3 years ago

fmendezh commented 3 years ago

This PR supports the functionality described in issue #8

tucotuco commented 3 years ago

Yes, please. :-)

On Wed, Sep 16, 2020 at 12:03 PM Matt Blissett notifications@github.com wrote:

@MattBlissett commented on this pull request.

In geocode-api/src/main/java/org/gbif/geocode/api/service/GadmService.java https://github.com/gbif/geocode/pull/13#discussion_r489507069:

+import javax.annotation.Nullable; +import javax.validation.constraints.Max; +import javax.validation.constraints.Min; + +public interface GadmService { +

  • Collection listLevel0(@Nullable String query);
  • Collection listLevel1(@Nullable String query, String gid0);
  • Collection listLevel2(@Nullable String query, String gid0, String gid1);
  • Collection listLevel3(@Nullable String query, String gid0, String gid1, String gid2);
  • PagingResponse search(@Nullable String query,
  • @Max(value = 2, message = "Only levels 0, 1 and 2 are supported")

Shouldn't level 3 be supported?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gbif/geocode/pull/13#pullrequestreview-489718141, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADQ723VDAR7CXVEPKUJXJLSGDHTXANCNFSM4Q6JIOQQ .

fmendezh commented 3 years ago

I didn't check the queries. The rest seems ok. The formatting seems random in some places though. I agree the format is odd everywhere but I prefer to do commit fixing the entire format for this project later