gbif / geocode

Geocode webservice and client
Apache License 2.0
5 stars 4 forks source link

Migrate geocode to SpringBoot and fasterxml.jackson #7

Closed fmendezh closed 4 years ago

fmendezh commented 4 years ago

The geocode service must be migrated to SpringBoot, this aims to bring consistency among all the frameworks and libraries used by the GBIF services. The following is a list of consideration that must be taken into consideration:

marcos-lg commented 4 years ago

@mike-podolskiy90 I was already working on another branch (it's not pushed yet though)

mike-podolskiy90 commented 4 years ago

I deleted that branch

MattBlissett commented 4 years ago

I've finished what I want to do with the geocoder, so this branch can be merged into master, preferably as a squash commit, git merge --squash origin/spring-boot-migration. It's then ready for release.

The prod_eez database (as well as uat_eez and dev_eez) contains the newest data.

marcos-lg commented 4 years ago

It's merged and deployed in DEV. It seems stable but it would be good if you @MattBlissett can do a quick round of testing. Also, it'd be helpful if you could test the DockerFile too.

MattBlissett commented 4 years ago

Regenerating cache bitmaps no longer works, as it can't initialize without them:

rm ./geocode-ws/src/main/resources/org/gbif/geocode/ws/layers/wgsrpd.png
rm ./geocode-ws/src/main/resources/org/gbif/geocode/ws/resource/cache-bitmap.png
mvn clean install -DskipTests -Pdev

But otherwise I think all is fine.

marcos-lg commented 4 years ago

I just pushed a fix for that.

MattBlissett commented 4 years ago

That now works, although I was unable to release the project.

marcos-lg commented 4 years ago

The release is fixed now. I had to create many unnecessary releases to test the problem with the empty snapshots and hence the commit history got a bit dirty.

I think the only thing missing now is the config to deploy in UAT and PROD. We can create them when we're planning to deploy it.

MattBlissett commented 4 years ago

Thanks, that's great. I've tidied up the mess, by branching from just before what was geocode-0.16, squash-merging all the changes to the POM, and releasing. I've removed all the test tags from Git, and all the test releases from Nexus.

You will need to "git reset" to get onto the new master branch, or else re-clone.