gbif / hosted-portals

Support material for establishing the GBIF Hosted Portals
Apache License 2.0
9 stars 6 forks source link

establishmentMeans changed from enum til vocabulary #211

Closed MortenHofft closed 2 years ago

MortenHofft commented 2 years ago

The API is changing how establishmentMeans is processed. It has changed from being interpreted as an enumeration and is instead a vocabulary

changes filters That means that the filter will need to use the vocabulary endpoints for suggest, and that it isn't a fixed list we can/should store in code. Should be closed by: https://github.com/gbif/gbif-web/commit/db8810fc93e60d5384a3efd10908df7849d85679 https://github.com/gbif/gbif-web/commit/d2099b07acfbcc28ed23da9773db25486feea65c https://github.com/gbif/gbif-web/commit/b3ac073f60c7ecc1df88c970449bdd9ad42d4aea

changes translations It also means that translations won't work from CrowdIn, but have to be taken from the vocabulary endpoint. has own issue https://github.com/gbif/hosted-portals/issues/212

changes in flow for translators In a team discussion we decided to not burden the translators with yet another UI to translate in and instead create a script that updated the vocabularies from e.g. Crowdin. This is handled elsewhere (or will be)

GraphQL We need to change the graphql schema as those will fail when the values no longer match the assumed enumeration. The simplest would be to change it to a plain string instead. So far our graphql isn't locality sensitive, but if we decided to make it so, then we could resolve the values against the vocabulary service. UPDATE: turns out we never properly mapped GraphQL to use the establishmentMeans enum, so it will just continue to be a String.