search

gbif / hosted-portals

Support material for establishing the GBIF Hosted Portals
Apache License 2.0
10 stars 6 forks source link

literature limit not working #220

Closed MortenHofft closed 1 year ago

MortenHofft commented 2 years ago

We recently moved the literature endpoint from using APIv1 to go straight to ElasticSearch (this was done to allow users to have richer scopes). In that process the limit parameter stopped working.

albenson-usgs commented 1 year ago

@MortenHofft would this be the reason the literature on gbif.us is not paging correctly? The issue is that no matter what page you go to it's the same papers listed.

MortenHofft commented 1 year ago

It sounds likely, though at the time when I created this issue it was my conclusion that this only mattered for a single user of the unstable API and hence wasn't a priority. I will check, it sounds a lot like I've missed something! Thank you for bringing it up.

MortenHofft commented 1 year ago

It is fixed and is deployed to staging. @frafra I'm not sure if this influence you. I cannot remember the details of how you use the API if at all using Graphql or the stable API v1. But the parameters for paging and the response format has changed slightly. It is now called total and not count in the response graphql schema

frafra commented 1 year ago

@MortenHofft Thank you, it was easy to fix that thanks to your message :) https://github.com/gbif/hp-living-norway/commit/851e50e905c68e940e57ebd508a4930c6b52240c