search

gbif / hp-beaty-biodiversity-museum

This repository is for the GBIF Hosted Portal for the Beaty Biodiversity Museum
https://collections.beatymuseum.ubc.ca
Apache License 2.0
1 stars 3 forks source link

Make sure all clickable links have aria labels #78

Closed mpitblado closed 9 months ago

mpitblado commented 9 months ago

Here I have adapted some of the base components from hp-jekyll-theme to take aria as an argument/parameter (not sure what they are called in jekyll). I will probably use the same approach for image alt texts. Not sure if the way I have implemented it is the way it is supposed to be done, but it seems to work as intended when browsing the site with the firefox accessibility inspector. I will read up on what the best phrasing is for said aria-labels, but now the underlying technical bits appear to be working.

Note that this only covers the root page. I am not sure what to do with 

columns:
  - description: |
      [<img alt="The Beaty Biodiversity logo" src="/assets/images/beaty-logo-horizontal.png"/>](https://beatymuseum.ubc.ca)

I believe that right now the alt text gets carried over as the aria-label but will have to investigate.