search

gbif / hp-grscicoll

https://grscicoll.hp.gbif-staging.org
2 stars 3 forks source link

Collections cannot be searched by institution key #169

Closed ManonGros closed 1 month ago

ManonGros commented 1 month ago

Describe the bug This doesn't seem to work: https://scientific-collections.gbif.org/collection/search?institution=dcb3162a-9409-4785-a86a-fa6b9b805d1d But the API calls does: https://api.gbif.org/v1/grscicoll/collection/search?institution=dcb3162a-9409-4785-a86a-fa6b9b805d1d

I am not sure why. @MortenHofft could you take a look? Thanks!

MortenHofft commented 1 month ago

Both work now, but we have seen something like it before. It is a case of the API failing. I cannot do anything about that. But the issue arise because the error is cached somewhere. That we should be able to fix. I'm not sure in what layer it is cached though.

ManonGros commented 1 month ago

@MortenHofft https://scientific-collections.gbif.org/collection/search?institution=dcb3162a-9409-4785-a86a-fa6b9b805d1d still doesn't give me the result I expect. This is a bit surprising.

MortenHofft commented 1 month ago

ahh - i misunderstood. I understood it as the page failed. It didn't for me. So I assumed it was the bug we have seen in the past with bad caching. Sorry.

You mean that the results aren't the correct ones. That it shows all collections and not just the expected subset from that institution. explanation: The field has been renamed in the API and I didn't adapt the UI. I should have a test for that. And the UI used the old field that have been replaced. I'm deploying a fix now and will avoid any prod changes for the next week. We have some small features and clean ups I would like to do when you are back from tdwg